Your current coupler is installed properly. All your symptoms stem from wear on the splines of the coupler. It is c-clipped in place, so you'll have to remove that clip to get the coupler off the drive shaft. It's a PITA because it is so deep. Was still easier for me than replacing the whole drive shaft. The splines between the drive shaft and the coupler do not move, so they should be undamaged. The splines between the coupler and the final drive DO move, so a little wear can cause some overlap, crunching, and jamming. The spring is quite stiff (takes up slack in the drive shaft when going over pot-holes, roughly the same job as suspension springs), so if it isn't broken, it is likely still good.
The original wear on the coupler was probably due to inadequate lubrication, and the sliding of the splines back and forth as your suspension moved (as intended) wore away the material (not intended). The PO probably replaced the final drive, but not the coupler, added lube, and shipped it. The (newish?) final drive splines are showing wear due to slipping past the worn splines on the coupler. The damage isn't too bad, so a new coupler should engage well enough to not slip. The mating surfaces won't be perfect due to the small amount of damage now present on the final drive splines, so wear will be slightly accelerated, but should last a long long time if kept properly lubed.